From 310ce1643a0fc22cef3e1c6d6f46e5f7df1ee32e Mon Sep 17 00:00:00 2001 From: Qian Wang Date: Sat, 12 Jan 2019 14:16:31 +0000 Subject: [PATCH] Minor Makefile edit and remove FIXME --- Makefile | 2 ++ internal/multiplex/switchboard.go | 11 ----------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index 058efcc..e438eb5 100644 --- a/Makefile +++ b/Makefile @@ -7,10 +7,12 @@ version=$(shell ver=$$(git log -n 1 --pretty=oneline --format=%D | awk -F, '{pri echo $$ver) client: + mkdir build go build -ldflags "-X main.version=${version}" ./cmd/ck-client mv ck-client* ./build server: + mkdir build go build -ldflags "-X main.version=${version}" ./cmd/ck-server mv ck-server* ./build diff --git a/internal/multiplex/switchboard.go b/internal/multiplex/switchboard.go index bb85589..ad823ca 100644 --- a/internal/multiplex/switchboard.go +++ b/internal/multiplex/switchboard.go @@ -148,17 +148,6 @@ func (sb *switchboard) deplex(ce *connEnclave) { continue } - // FIXME: there has been a bug in which a packet has - // a seemingly corrupted StreamID (e.g. when the largest streamID is something like 3000 - // and suddently a streamID of 3358661675 is added. - // It happens once ~6 hours and the occourance is realy unstable - // I couldn't find a way to reproduce it. But I do have some clue. - // I commented out the util.genXorKeys function so that the stream headers are being - // sent in plaintext, and this bug didn't happen again. So I suspect it has to do - // with xxHash. Either it's to do with my usage of the libary or the implementation - // of the library. Maybe there's a race somewhere? I may eventually use another - // method to encrypt the headers. xxHash isn't cryptographic afterall. - stream := sb.session.getStream(frame.StreamID, frame.Closing == 1) // if the frame is telling us to close a closed stream // (this happens when ss-server and ss-local closes the stream