From 20a5f3fdf66755b3cf0834be4db4bf8180673c02 Mon Sep 17 00:00:00 2001 From: Artem Pinchuk Date: Thu, 18 Apr 2019 16:16:05 +1000 Subject: [PATCH] Fixed issue with special chars in login credentials --- .../java/me/legrange/mikrotik/impl/ApiConnectionImpl.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/me/legrange/mikrotik/impl/ApiConnectionImpl.java b/src/main/java/me/legrange/mikrotik/impl/ApiConnectionImpl.java index d7ef24f..f8fddeb 100644 --- a/src/main/java/me/legrange/mikrotik/impl/ApiConnectionImpl.java +++ b/src/main/java/me/legrange/mikrotik/impl/ApiConnectionImpl.java @@ -55,7 +55,10 @@ public final class ApiConnectionImpl extends ApiConnection { if (username.trim().isEmpty()) { throw new ApiConnectionException("API username cannot be empty"); } - List> list = execute("/login name=" + username + " password=" + password); + Command cmd = new Command("/login"); + cmd.addParameter("name", username); + cmd.addParameter("password", password); + List> list = execute(cmd, timeout); if (!list.isEmpty()) { Map res = list.get(0); if (res.containsKey("ret")) {